Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build htslib 1.16 #3

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Build htslib 1.16 #3

merged 1 commit into from
Jan 3, 2024

Conversation

jdblischak
Copy link
Collaborator

This PR builds m2w64-htslib using htslib 1.16

xref: TileDB-Inc/tiledb-vcf-feedstock#106

I removed the patchfile for htslib/vcf.h because it is no longer needed (and the build fails if patch tries to apply an unneeded patchfile):

https://github.com/samtools/htslib/blob/4e61c128238f3e7cbb3b1f4e9c0fdb4880aa9a10/htslib/vcf.h#L1435-L1439

HTSLIB_EXPORT
extern uint32_t bcf_float_vector_end;
HTSLIB_EXPORT
extern uint32_t bcf_float_missing;
static inline void bcf_float_set(float *ptr, uint32_t value)

Ideally we will eventually build htslib 1.19, but I'm currently getting build errors

@jdblischak jdblischak self-assigned this Jan 3, 2024
@jdblischak
Copy link
Collaborator Author

The linking is still the same as the previous build:

Dump of file hts-3.dll
File Type: DLL
    ADVAPI32.dll
    KERNEL32.dll
    msvcrt.dll
    USER32.dll
    WS2_32.dll
    bcrypt.dll
    CRYPT32.dll
    WLDAP32.dll

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdblischak jdblischak merged commit 8a2596a into TileDB-Inc:main Jan 3, 2024
2 checks passed
@jdblischak jdblischak deleted the htslib-1.16 branch January 3, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants