-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize feedstock for TileDB-Inc #60
Conversation
More details at https://conda-forge.org/docs/maintainer/conda_forge_yml.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after changing the gcc target back to 10 as discussed.
@ihnorton Updated so it only rerenders the README for now Strangely, the CI still wasn't triggered. Also, the CI jobs for PR #42 weren't restarted after you opened and closed the PR this morning The azure jobs have been running as recently as this Tuesday, so I'm not sure what happened to change this |
I can now see CI jobs displayed at the bottom of the PR (screenshot below), but they aren't functional. They can't be clicked, the Checks tab for the PR is still empty, and these jobs don't exist on Azure I'll try opening and closing again, but I'm at a loss at how to fix this |
@awenocur Could you please review this PR and investigate the issue with the stalled/non-existent CI jobs? |
@jdblischak I'm looking at the checks, but having difficulty restarting them. Sometimes when I push a fake commit, then force-push to revert back to the intended commit, GitHub will trigger actions again. |
Two updates post commit a5c01af:
@awenocur Could you please review and merge? I can't get the CI jobs to run no matter what I do. But as you can see, the edits I made don't affect the recipe build process, so I don't think the tests are necessary. |
This is a quality of life PR. I noticed the badges and instructions in the README were all for the conda-forge org and channel. Now they apply to TileDB-Inc GitHub org and the tiledb channel.
Specifically, I did the following:
user_or_org: TileDB-Inc
updates some URLs in the READMEtooling_branch_name: main
this ensures that future conda-smithy rerenders don't undo the changes from PR Change github action branches to main #58channels
updates the badge links to anaconda.org as well as the README installation instructions (note that the channels set inrecipe/conda_build_config.yaml
affect the build process, but not the feedstock rerendering)