Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize feedstock for TileDB-Inc #60

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

jdblischak
Copy link
Collaborator

This is a quality of life PR. I noticed the badges and instructions in the README were all for the conda-forge org and channel. Now they apply to TileDB-Inc GitHub org and the tiledb channel.

Specifically, I did the following:

  • user_or_org: TileDB-Inc updates some URLs in the README
  • tooling_branch_name: main this ensures that future conda-smithy rerenders don't undo the changes from PR Change github action branches to main #58
  • channels updates the badge links to anaconda.org as well as the README installation instructions (note that the channels set in recipe/conda_build_config.yaml affect the build process, but not the feedstock rerendering)

@jdblischak
Copy link
Collaborator Author

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changing the gcc target back to 10 as discussed.

@jdblischak
Copy link
Collaborator Author

@ihnorton Updated so it only rerenders the README for now

Strangely, the CI still wasn't triggered. Also, the CI jobs for PR #42 weren't restarted after you opened and closed the PR this morning

The azure jobs have been running as recently as this Tuesday, so I'm not sure what happened to change this

https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=35

@jdblischak
Copy link
Collaborator Author

I can now see CI jobs displayed at the bottom of the PR (screenshot below), but they aren't functional. They can't be clicked, the Checks tab for the PR is still empty, and these jobs don't exist on Azure

image

I'll try opening and closing again, but I'm at a loss at how to fix this

@jdblischak jdblischak closed this Dec 12, 2022
@jdblischak jdblischak reopened this Dec 12, 2022
@jdblischak
Copy link
Collaborator Author

@awenocur Could you please review this PR and investigate the issue with the stalled/non-existent CI jobs?

@awenocur
Copy link
Contributor

awenocur commented Dec 16, 2022

@jdblischak I'm looking at the checks, but having difficulty restarting them. Sometimes when I push a fake commit, then force-push to revert back to the intended commit, GitHub will trigger actions again.

@jdblischak
Copy link
Collaborator Author

jdblischak commented Dec 16, 2022

@awenocur Thanks for investigating. I've changed this PR to a draft for now. I'll return to it once we've merged #62

@jdblischak jdblischak marked this pull request as ready for review December 19, 2022 20:26
@jdblischak
Copy link
Collaborator Author

Two updates post commit a5c01af:

  1. The rerendering in that commit reverted the tooling branch back to "master", effectively undoing PR Change github action branches to main #58. Defining tooling_branch_name: main will prevent this from happening again in the future
  2. Now that htslib is being built from source due to solver issues, I removed the bioconda channel

@awenocur Could you please review and merge? I can't get the CI jobs to run no matter what I do. But as you can see, the edits I made don't affect the recipe build process, so I don't think the tests are necessary.

@Shelnutt2 Shelnutt2 merged commit c0054e2 into TileDB-Inc:master Dec 21, 2022
@jdblischak jdblischak deleted the rerender branch December 21, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants