Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: inline formatting #28

Closed
wants to merge 1 commit into from

Conversation

varphi-online
Copy link
Contributor

It is my understanding that primarily text based RSS readers like Newsboat strip html tags that they cannot render, so I thought preserving styling information for the RSS readers that do handle them would create a better end user experience. As for spacing, i have no idea why it is not working, my config in VSC is 2 space indents, so sorry for a third time 🥲.
image
image
image

@TimoKats
Copy link
Owner

Hi @varphi-online, thanks for another suggestion. I'll look at it when I get home later today. The tab/spaces thing is not difficult to solve for me (regex replace \t), so no worries!

I do think I'll restructure the markdown submodule after this merge, since it's becoming a bit too large. Thanks!

@varphi-online
Copy link
Contributor Author

Gotcha! And yeah, the module was getting really big, I tried extracting the logic for most inlining things into a function to reduce some of it.

@TimoKats
Copy link
Owner

Ok! Btw, I didn't get to reviewing yesterday evening, sorry for that, hopefully today.

@varphi-online
Copy link
Contributor Author

Oh, no worries! I know this is a side project, and don't expect any kind of timeframe for things like these, I'm just happy to be working on something! 😄

@TimoKats
Copy link
Owner

TimoKats commented Sep 16, 2024

@varphi-online The feature is merged and you're credited as a co-author. I also did quite a bit of overall refactoring. Long story short, all the conversions are now in a converter submodule. Regardless, I still find the project a bit to messy for a v1.0.0, but it's defs heading in the right direction.

In any event, after a long day of work, and an evening of open source work, I think I deserve a beer. Maybe I'll listen to some of the music on your website to relax🤔...thanks again!

@TimoKats TimoKats closed this Sep 16, 2024
@varphi-online
Copy link
Contributor Author

varphi-online commented Sep 16, 2024

Of course! Everything is so much cleaner and easy to follow now, definitely a major improvement from before and I can also see the data structures you scaffolded for further refactoring in the future. I'm excited to see this project become more feature-rich and useful!

A beer sounds like a wonderful way to cap off an extra-long day of programming, and I am glad to hear my music might be able to help unwind 😄 Have a wonderful night! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants