Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal(s): Extended configuration options & Interactive Prompt #30

Closed
wants to merge 5 commits into from

Conversation

varphi-online
Copy link
Contributor

@varphi-online varphi-online commented Sep 17, 2024

Reading the RSS 2.0 Spec for this project, I realized how many optional elements are allowed, and I wanted to extend that customizability to the user, so I added/moved around some of the config struct to accommodate for this.

Conversely, I absolutely love programs that make set-up fast, easy, and simple, so I have committed an interactive prompt that takes the user through a series of 6 required questions to get right into converting, while simultaneously creating the config file if it wasn't there already, and scaffolding for all the extensible options from above (with json.Marshal)
image
image
I just thought this would be nice to provide to possibly less-experienced Linux users who want to use the project 😄

@varphi-online varphi-online marked this pull request as draft September 17, 2024 17:26
@varphi-online varphi-online marked this pull request as ready for review September 17, 2024 17:28
@varphi-online varphi-online marked this pull request as draft September 17, 2024 18:46
@varphi-online
Copy link
Contributor Author

Oh, of course! I apologize, I was unaware that was a limited resource, I will be sure to be more careful in the future with how often I'm pushing commits. Sorry again!

@varphi-online varphi-online marked this pull request as ready for review September 17, 2024 18:57
@TimoKats
Copy link
Owner

Hi @varphi-online. Thanks for the PR. Will look at it later this week

@TimoKats
Copy link
Owner

Hi @varphi-online , I merged a slightly lessened version of your fix. I quite like the idea of an init command, but I kept the config as it is for now. You're credited as a co-author and actually mentioned in the README when it comes to this new command :)

@TimoKats TimoKats closed this Sep 20, 2024
@varphi-online
Copy link
Contributor Author

Hi @TimoKats, glad to hear the init command got added :) Also, thank you for the README credit, I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants