Add batch with db transaction

[Shusshu]

Ability for the ProviGenProvider to execute a bunch of insert/delete/update within a database transaction

[Shusshu]

Oups I just saw my commit changed the whole file... this is not normal...

I only added 1 method at the end :
@OverRide
public ContentProviderResult[] applyBatch(ArrayList operations) throws OperationApplicationException {

[TimotheeJeannin]

Hi @Shusshu,

Thank you for this pull request.

Can you clarify what the db.yieldIfContendedSafely(); is for ?

Can you make your commit not change the whole file ?

Adding javadoc and matching current code style would appreciated too. :)

Tim

[Shusshu]

Hello,

I don't get it I apply your code formatter but it just doesn't change anything, actually I didn't even change the formatting so I have no idea why the whole file is marked as changed

About db.yieldIfContendedSafely() it is supposed to be able to let other threads use the db during that transaction

[Shusshu]

updated to have a nice diff

[Shusshu]

Any plan to include this soon?

[TimotheeJeannin]

Hi @Shusshu,

The idea behind ProviGen is:

Annotate a ContractClass and ProviGen will provide a ContentProvider for that contract.

There is already a default implementation of the applyBatch method:

public ContentProviderResult[] applyBatch(ArrayList<ContentProviderOperation> operations)
        throws OperationApplicationException {
    final int numOperations = operations.size();
    final ContentProviderResult[] results = new ContentProviderResult[numOperations];
    for (int i = 0; i < numOperations; i++) {
        results[i] = operations.get(i).apply(this, results, i);
    }
    return results;
}

Using transactions is a great way to improve performance of the executed ContentProviderOperations, and I agree overriding the applyBatch method is the right way to go if the application heavily uses ContentProviderOperations. But I feel like it's more the developer's responsibility to override the applyBatch method than ProviGen's responsibility.

It's a bit as if ProviGen was : A library to generate a ContentProvider from a ContractClass and also it will override the applyBatch method to use transactions ... it sounds a bit weird ...

See issue #28, I would like to discuss the overall organisation of ProviGen regarding more advances features like transactions.

[Shusshu]

Yes you make a good point there :)
I'll read the other issues

[Shusshu]

In ProviGen 2.0.0
SQLiteDatabase db = openHelper(getContext()).getWritableDatabase();