Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus: allow customising scraping #44

Merged
merged 4 commits into from
Feb 26, 2025
Merged

prometheus: allow customising scraping #44

merged 4 commits into from
Feb 26, 2025

Conversation

NightTsarina
Copy link
Member

  • 59f9e02 - prometheus: reorder scrape configurations
  • ac95f94 - prometheus: add prometheus__monitored_alermanagers var
  • 1c7811a - prometheus: add vars to allow customising scraping

@dato dato changed the base branch from v2 to ansible-compat-ignore February 21, 2025 12:27
dato
dato approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@dato dato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from ansible-compat-ignore to v2 February 21, 2025 17:19
dunetna
dunetna approved these changes Feb 26, 2025
View reviewed changes
@NightTsarina @dunetna
Apply suggestions from code review
cfd2c38 
Co-authored-by: Mònica Ramírez Arceda <monica@probeta.net>
@NightTsarina NightTsarina merged commit 6e2edb2 into v2 Feb 26, 2025
2 checks passed
@NightTsarina NightTsarina deleted the scrape_configs branch February 26, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dato dato dato approved these changes

@dunetna dunetna dunetna approved these changes

@sim6 sim6 Awaiting requested review from sim6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NightTsarina @dato @dunetna