Feature/add authentication timeout #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIQR-452: Add authenticationTimeout in seconds to push notifications. This allows a client to decide for how long to offer an authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "authenticationTimeout" customProperty to push notifications.
The authenticationTimeout is the number of seconds for which the authentication push notification should be actionable by the user after the push notification is sent. The server should set this to an appropriate number of seconds that allows the user to complete the timeout before the session on the server. We now use [server authentication session timeout] - 30 seconds = 150 seconds. So this gives a user at least 30 seconds to complete the authentication. A Tiqr client should not offer to stat an authentication after authenticationTimeout, but it should allow it to be completed even after authenticationTimeout expires.
mutable-content: 1option