Added 3 more requests #412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishka17
reviewed
Jul 14, 2024
| def __init__( | ||
| self, | ||
| text: Text, | ||
| RequestButton: KeyboardButtonRequestChat, |
Tishka17
reviewed
Jul 14, 2024
| [ | ||
| KeyboardButton( | ||
| text=await self.text.render_text(data, manager), | ||
| request_user=self.RequestButton, |
There was a problem hiding this comment.
I am not sure it is good idea to have static request_id`
There was a problem hiding this comment.
What do you mean? If I'm not mistaking, there're no static request_id. We provide RequestButton above which was set up earlier by developer.
There was a problem hiding this comment.
I mean once you declare widget in dialog, it will have same request id here.
There was a problem hiding this comment.
Static request_id is not a problem in itself since it must be unique within the message, not within the whole chat history.
https://core.telegram.org/bots/api#keyboardbuttonrequestusers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 more button requests: