Skip to content

Conversation

@jwindhager
Copy link
Member

... to match Float32Array

(Float16Array is only supported from ECMAScript 2025 onwards)

@jwindhager jwindhager self-assigned this Jan 20, 2026
Copilot AI review requested due to automatic review settings January 20, 2026 14:00
@jwindhager jwindhager added the bug Something isn't working label Jan 20, 2026
@jwindhager
Copy link
Member Author

Thanks @cavenel for reporting this bug!

@jwindhager jwindhager merged commit b549d9a into main Jan 20, 2026
5 checks passed
@jwindhager jwindhager deleted the fix/pointsize-buffer-type branch January 20, 2026 14:01
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5976c9e) to head (c74d00d).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##            main       #50       +/-   ##
===========================================
+ Coverage   4.41%   100.00%   +95.58%     
===========================================
  Files         77         5       -72     
  Lines       4324        71     -4253     
  Branches     112        17       -95     
===========================================
- Hits         191        71      -120     
+ Misses      4098         0     -4098     
+ Partials      35         0       -35     
Flag Coverage Δ
unittests 100.00% <ø> (+95.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a WebGL buffer type mismatch in the point size buffer configuration. The buffer was incorrectly configured to use HALF_FLOAT type while the actual data being loaded is Float32Array, causing a type incompatibility. Since Float16Array is only supported from ECMAScript 2025 onwards, the buffer type must be FLOAT to match the Float32Array data.

Changes:

  • Changed the WebGL buffer type for the point size attribute from HALF_FLOAT to FLOAT to match the Float32Array data type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants