Skip to content

Conversation

Copy link

Copilot AI commented Jan 27, 2026

The groupBy completion check incorrectly required both currentGroupByProjectMap AND currentGroupByMap to be non-null before updating the config. Per the GroupByConfig API design, either projectMap OR map should be provided, not both.

Changes

  • Updated condition in ColorConfigContextProvider and SizeConfigContextProvider from && to || logic
  • Config now updates when at least one mapping field is initialized (non-null)
  • Preserves three-state semantics: null (uninitialized), undefined (deliberately empty), or a value
// Before: Required both fields
currentGroupByProjectMap !== null &&
currentGroupByMap !== null &&

// After: Requires at least one field
(currentGroupByProjectMap !== null || currentGroupByMap !== null) &&

This allows the user to set either a project-global mapping (projectMap) or a custom mapping (map) independently, matching the API contract.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: jwindhager <7105759+jwindhager@users.noreply.github.com>
Copilot AI changed the title [WIP] Update currentGroupBy variables in PointsPanel to address feedback Fix groupBy condition to allow either projectMap or map, not require both Jan 27, 2026
Copilot AI requested a review from jwindhager January 27, 2026 15:04
@jwindhager jwindhager closed this Jan 27, 2026
@jwindhager jwindhager deleted the copilot/sub-pr-48 branch January 27, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants