Skip to content

Skill endorsements #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Sappymukherjee214 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Skill endorsements #156

Sappymukherjee214 wants to merge 5 commits into from

Conversation

@Sappymukherjee214
Copy link
Contributor

@Sappymukherjee214 Sappymukherjee214 commented Jan 14, 2026 •
edited
Loading

📝 Description

This PR introduces a peer-based Developer Skill Endorsement system that allows users to showcase their skills on their profiles and receive endorsements from other community members, building trust and credibility within the DevConnect platform.

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ⚡ Performance improvement
  • ♿ Accessibility improvement
  • 🔧 Refactoring

🔗 Related Issues

Issue #155

📋 Changes Made

  • Created Skills and SkillEndorsements database tables with RLS policies
  • Implemented SkillsSection component for profile skill management
  • Added custom hooks (useSkills) for skill CRUD and endorsement operations
  • Integrated skill endorsements into ProfilePage
  • Added TypeScript interfaces for type safety
  • Included comprehensive documentation in SKILL_ENDORSEMENT.md
  • Updated README with skill endorsement feature details

🧪 Testing

  • Unit tests added/updated
  • Tested on desktop
  • Tested on mobile
  • Manual testing completed

Testing Steps:

  1. Navigate to /profile page
  2. Click "Add Skill" button and add a skill (e.g., "React", "TypeScript")
  3. Verify skill appears in the skills section
  4. Visit another user's profile (if available)
  5. Click the thumbs-up icon to endorse their skills
  6. Verify endorsement count increases
  7. Click again to remove endorsement
  8. Try to endorse your own skills (should be disabled)
  9. Test in both light and dark mode

📦 Dependencies

  • No new dependencies
  • New dependencies added (list below)

✅ Checklist

Code Quality

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran npm run lint and fixed all issues

Testing & Functionality

  • I have tested my changes thoroughly
  • New and existing tests pass locally with my changes
  • I have added tests that prove my fix is effective or my feature works

Documentation

  • I have updated the documentation accordingly
  • I have updated the README if needed
  • I have added/updated inline comments where necessary

Git & Commits

  • My commits have clear, descriptive messages
  • My branch is up to date with the base branch
  • I have not included unnecessary commits

Breaking Changes

  • This PR does not introduce breaking changes
  • I have documented any breaking changes clearly

📝 Additional Context

Database Setup Required:
Before merging, the database schema must be executed in Supabase:

-- Run the contents of database-schema-skills.sql in Supabase SQL Editor

Key Features:

  • Users can add/remove skills on their profile
  • Other users can endorse skills (one endorsement per skill per user)
  • Real-time endorsement counts displayed
  • Self-endorsement prevention via RLS policies
  • Dark mode support with responsive design

Security:

  • Row Level Security (RLS) policies prevent self-endorsements
  • Unique constraints prevent duplicate skills and endorsements
  • Cascade deletes maintain referential integrity

🔍 Reviewer Notes

Please pay special attention to:

  • Database schema and RLS policies - Ensure security policies are correctly implemented
  • TypeScript types - Verify all interfaces are properly defined
  • Component architecture - Check if hooks are used efficiently
  • UI/UX - Test the component in both light and dark modes
  • Error handling - Verify appropriate error messages are shown

🚀 Deployment Notes

Pre-deployment steps:

  1. Execute database-schema-skills.sql in Supabase SQL Editor
  2. Verify Skills and SkillEndorsements tables are created
  3. Confirm RLS policies are enabled on both tables
  4. Test with multiple user accounts to verify endorsement flow

No breaking changes - This feature is additive and doesn't affect existing functionality.

@Sappymukherjee214
feat: Add custom DevConnect favicon
9cb703e 
- Replace default Vite favicon with custom DevConnect design
- Create devconnect-favicon.svg with network connectivity theme
- Update index.html to reference new favicon
- Improve page title for better branding
@Sappymukherjee214
feat: add peer-based skill endorsement system
d6a4b01
@vercel
Copy link

vercel bot commented Jan 14, 2026

@Sappymukherjee214 is attempting to deploy a commit to the Divya Tiwari's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 Hi @Sappymukherjee214,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@netlify
Copy link

netlify bot commented Jan 14, 2026 •
edited
Loading

❌ Deploy Preview for tiwaridivya25-devconnect failed.

Name Link
🔨 Latest commit 556b45d
🔍 Latest deploy log https://app.netlify.com/projects/tiwaridivya25-devconnect/deploys/6967c8187e9df40008eaa632

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 Hi @Sappymukherjee214,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 Hi @Sappymukherjee214,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 Hi @Sappymukherjee214,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 Hi @Sappymukherjee214,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@Sappymukherjee214
Copy link
Contributor Author

Sappymukherjee214 commented Jan 14, 2026

@TiwariDivya25 I have added the developer skill endorsements. Please label the PR for the issue #155

@Sappymukherjee214
Copy link
Contributor Author

Sappymukherjee214 commented Jan 15, 2026

@TiwariDivya25 I have already created the PR for the issue. Please label the PR for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sappymukherjee214