Skip to content

Handling child text nodes of div #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaviBolla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handling child text nodes of div #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/reader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,10 +439,8 @@ function getCandidates ($, options) {
}
// cache innerText here.
var childDom = child.get(0)
var innerText
if (childDom.type === 'text' && (innerText = childDom.data.trim())) {
child.replaceWith('<p class="' + extBonusKey + '">' + innerText + '</p>')
innerText = null
if (childDom.type === 'text' && childDom.data.trim()) {
child.replaceWith('<span class="' + extBonusKey + '">' + childDom.data + '</span>')
}
})
}
Expand All @@ -452,7 +450,7 @@ function getCandidates ($, options) {
}
})
// assign scores to `P`s that were turned from DIV by us.
$('p.' + extBonusKey, 'body').each(function () {
$('p.' + extBonusKey + ',span.' + extBonusKey, 'body').each(function () {
getNodeWeight($(this), cans, options)
})
return cans
Expand Down