Skip to content

Conversation

masonhfisher
Copy link

A small patch for the ttkwidgets.autocomplete.AutocompleteCombobox that adds an argument to the initializer method that allows the user to decide if they want their list to be sorted automatically or not.

The option to sort automatically is set to True by default to maintain backwards compatibility with older versions of ttkwidgets.

The patch is made for the reason that sometimes you probably don't want your list to be sorted (like for example in my case, a list of months).

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.68%. Comparing base (ebaa7d4) to head (19870ca).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   89.53%   86.68%   -2.85%     
==========================================
  Files          43       43              
  Lines        4032     4154     +122     
==========================================
- Hits         3610     3601       -9     
- Misses        422      553     +131     
Files with missing lines Coverage Δ
ttkwidgets/autocomplete/autocompletecombobox.py 91.02% <100.00%> (+0.35%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaa7d4...19870ca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@masonhfisher masonhfisher changed the title Combobox patch AutocompleteCombobox: Optional sorting Oct 2, 2025
sbordeyne
sbordeyne previously approved these changes Oct 3, 2025
@sbordeyne
Copy link
Member

If you could add a small test to keep coverage stable, that would be great

Copy link
Member

@sbordeyne sbordeyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the coverage drop seems unrelated from looking at the more detailed codecov report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants