Fix startup if HAMLIB_KEYER selected and rig is off or disabled at start #416
Conversation
Otherwise TLF will abort unconditionally.
| if (trx_control_disabled) { | ||
| showmsg("Radio control disabled - no keying!"); | ||
| return; | ||
| } | ||
| if (!trx_control) { | ||
| showmsg("Radio control is not activated!!"); |
There was a problem hiding this comment.
Can we now reach this message? I.e. trx_control_disabled==false and trx_control==false
There was a problem hiding this comment.
Hmm, that state could only happen if you have RIGCONTROL disabled in logcfg.dat. Than having HAMLIB_KEYER activated seems to be an configuration error which is catched in the following if-statement. But I think that problem should be catched in parse_config() before.
There was a problem hiding this comment.
Indeed. Then the second if ("Radio control is not activated") has to be kept, even if only this quite specific use case triggers it. I'd not bother adding any other check for it.
On the other hand it may be worth promoting the message of the first if to a warning by adding a sleep. Now this message just flashed for a split second unless using verbose mode. Unless of course if we rely on the previous question (if the rig was off) or assume the user knows what they they are doing (if started with -r option).
There was a problem hiding this comment.
Good points. Give me a day or two to think about.
There was a problem hiding this comment.
Just added a 2 second delay (see commit below). should be enough to see a problem and restart with -v if needed.
Otherwise TLF will abort unconditionally.