Skip to content

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Feb 23, 2025

This PR updates the plugin and example/ application to support Tauri version 2.

BREAKING CHANGE: Tauri version 1 is no longer supported.
BREAKING CHANGE: Applications must now specify the needed capabilities from pty. See examples/vanilla/src-tauri/capabilities/default.json. For example:

{
  "$schema": "../gen/schemas/desktop-schema.json",
  "identifier": "default",
  "description": "Capability for the main window",
  "windows": [
    "main"
  ],
  "permissions": [
    "core:default",
    "pty:default",
    "os:default"
  ]
}

Cargo.toml Outdated
tauri = { version = "^2" }

[build-dependencies]
tauri-plugin = { version = "2.0.3", features = ["build"] }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this version should be "2" for consistency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed!

Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
@Tnze
Copy link
Owner

Tnze commented Feb 28, 2025

Does this PR ready to be reviewed?

@starpit
Copy link
Contributor Author

starpit commented Feb 28, 2025

Does this PR ready to be reviewed?

yes! thank you.

@starpit
Copy link
Contributor Author

starpit commented Mar 2, 2025

hmm, the clippy test seems to have succeeded, only to fail when trying to update an annotation?

Clippy results: 0 ICE, 0 errors, 0 warnings, 0 notes, 0 help
Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
Warning: It seems that this Action is executed from the forked repository.
Warning: GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See actions-rs/clippy-check#2 for details.
Posting clippy checks here instead.
Error: Clippy had exited with the 101 exit code

@Tnze
Copy link
Owner

Tnze commented Mar 10, 2025

Sorry for the delay. Github ​has being semi-banned on China so I can only access when lucy.

image

The example doesn't work?

@Tnze
Copy link
Owner

Tnze commented Mar 10, 2025

My bad, forget to npm install

@Tnze Tnze merged commit a43f16c into Tnze:main Mar 10, 2025
3 of 4 checks passed
@starpit
Copy link
Contributor Author

starpit commented Mar 10, 2025

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants