Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Thunderbird #642

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Add support for Thunderbird #642

merged 4 commits into from
Nov 15, 2024

Conversation

kewisch
Copy link
Contributor

@kewisch kewisch commented Oct 30, 2024

Hey Tobi,

Thunderbird is making an appearance very soon, so I thought we could add Thunderbird here as well.

Let me know if this works

Philipp

@Tobi823
Copy link
Owner

Tobi823 commented Nov 1, 2024

The PR looks good, I will check it + merge it after my vacation.

I hope that my source code was understandable :D

@kewisch
Copy link
Contributor Author

kewisch commented Nov 1, 2024

It was pretty smooth sailing, very straightforward to add! Enjoy your vacation 💯

@@ -25,7 +25,7 @@ object FirefoxRelease : AppBase() {
override val title = R.string.firefox_release__title
override val description = R.string.firefox_release__description
override val installationWarning = R.string.firefox_release__warning
override val downloadSource = "GitHub"
override val downloadSource = "Mozilla Archive"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I totally forgot to change this value

@@ -7,7 +7,7 @@

Installs and updates the following browsers:

Browsers from Mozilla or based on Firefox:
Software from Mozilla or based on Firefox:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Tobi823 Tobi823 merged commit 8dcf082 into Tobi823:master Nov 15, 2024
@Tobi823
Copy link
Owner

Tobi823 commented Nov 15, 2024

Thanks

@Tobi823
Copy link
Owner

Tobi823 commented Nov 15, 2024

@all-contributor please add @kewisch for code

@Tobi823
Copy link
Owner

Tobi823 commented Nov 15, 2024

@all-contributors please add @kewisch for code

Copy link
Contributor

@Tobi823

I've put up a pull request to add @kewisch! 🎉

@Tobi823
Copy link
Owner

Tobi823 commented Nov 15, 2024

FYI I only did a few minor improvements
8b6d84b
adcc988
fb590dd

Tobi823 added a commit that referenced this pull request Nov 24, 2024
- Thanks for the Weblate contributions from: Coool, tetify, jrthwlate, Cirnos, nautilusx, gallegonovato, 109247019824, hamburger2048, kazushi3 and Atalanttore
- Change Git signature key
- Add support for Thunderbird and Thunderbird Beta (thanks kewisch; #642)
- Fix K-9 Mail (thanks kewisch; #648)
- Fix network problems with HTTP 2.0 on some smartphones (thanks TeeTeeHaa; #629)
- Kiwi is now EOL
- Remove Bromite, Bromite SystemWebView, Lockwise and UngoogledChromium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants