Replace pymssql with pyodbc #3808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Failing ci due to pyodbc not being in the requirements. I've tried finding where to put it, but no luck. Any hints? |
Check setup.py, However - I don't think we want to replace pymssql, because that will break SQLMesh for every project that is currently using MSSQL the second they upgrade SQLMesh (by introducing a requirement to have ODBC set up and ODBC drivers installed) Have you considered implementing this as an option instead? Something like adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace pymssql in mssql in connectors with pyodbc.
This opens the ability to use other kind of authorisations, e.g., service principal. It will also be needed in the future in order to integrate with Microsoft Fabric.