-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding more logs! #103
Conversation
WalkthroughThe recent update focuses on enhancing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- discord_analyzer/analysis/compute_member_activity.py (6 hunks)
Additional comments not posted (5)
discord_analyzer/analysis/compute_member_activity.py (5)
110-110
: Good addition: Logging the start of member activities analysis.This logging statement provides useful information about the start of the member activities analysis for the given guild ID.
153-153
: Good addition: Logging the loading of past data.This logging statement provides useful information about the process of loading past data.
178-178
: Good addition: Logging the update of dictionaries.This logging statement provides useful information about the completion of the dictionary update process.
185-185
: Good addition: Logging the update of the date range.This logging statement provides useful information about the process of updating the date range.
197-197
: Good addition: Logging the update of joined members with past data.This logging statement provides useful information about the process of updating joined members with past data.
@@ -162,6 +165,8 @@ def compute_member_activity( | |||
] | |||
starting_key = 0 | |||
|
|||
logging.info(f"{guild_msg} loading past data!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant logging statement: Remove the duplicate log.
This logging statement is redundant as it repeats the message logged at line 153.
- logging.info(f"{guild_msg} loading past data!")
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
logging.info(f"{guild_msg} loading past data!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- discord_analyzer/analysis/compute_member_activity.py (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- discord_analyzer/analysis/compute_member_activity.py
Adding more logs to memberactivities to find out the problem of #102
Summary by CodeRabbit