routers/http.py (1)

40-56: Improved error handling, but consider enhancing error details.

The changes correctly prevent 500 errors by checking task status before accessing the result, and ensure data consistency by only persisting successful tasks.

Consider enhancing error handling by including more detailed error information in the response when the task is not successful. Here's a suggested improvement:

     if task.status == "SUCCESS":
         # persisting the data updates in db
         persister = PersistPayload()

         http_payload = HTTPPayload(
             communityId=task.result["community_id"],
             question=QuestionModel(message=task.result["question"]),
             response=ResponseModel(message=task.result["response"]),
             taskId=task.id,
         )
         persister.persist_http(http_payload, update=True)

         results = {"id": task.id, "status": task.status, "result": task.result}
     else:
-        results = {"id": task.id, "status": task.status}
+        results = {
+            "id": task.id,
+            "status": task.status,
+            "error": str(task.result) if task.result else None
+        }

     return results

worker/tasks.py (1)

9-24: Consider adding task resilience mechanisms.

The task could benefit from additional reliability features:

1. Retry mechanism for transient failures
2. Timeout handling for LLM queries
3. Task performance monitoring

Consider these enhancements:

 @app.task
+@app.task(
+    bind=True,
+    max_retries=3,
+    retry_backoff=True,
+    soft_time_limit=30,
+    time_limit=60
+)
-def ask_question_auto_search(
+def ask_question_auto_search(
+    self,
     community_id: str,
     query: str,
 ) -> dict[str, str]:
     try:
         response = query_data_sources(community_id=community_id, query=query)
+    except SoftTimeLimitExceeded:
+        logging.error("Task timed out for community %s", community_id)
+        raise self.retry(countdown=60)
     except Exception:
         response = "Sorry, We cannot process your question at the moment."
         logging.error(
             f"Errors raised while processing the question for community: {community_id}!"
         )

Also consider adding Prometheus metrics for monitoring task performance:

from prometheus_client import Counter, Histogram

TASK_LATENCY = Histogram('task_latency_seconds', 'Task latency in seconds')
TASK_ERRORS = Counter('task_errors_total', 'Total number of task errors')

Configuration used: CodeRabbit UI
Review profile: CHILL

         http_payload = HTTPPayload(
-            communityId=task.result["community_id"],
-            question=QuestionModel(message=task.result["question"]),
-            response=ResponseModel(message=task.result["response"]),
+            communityId=task.result.get("community_id"),
+            question=QuestionModel(message=task.result.get("question", "")),
+            response=ResponseModel(message=task.result.get("response", "")),
             taskId=task.id,
         )

#!/bin/bash
# Search for any remaining references to the removed function
rg "ask_question_auto_search_discord_interaction"

routers/http.py (2)

58-62: Consider standardizing the response structure.

The response structure differs between success and failure cases. Consider standardizing it to always include the same fields:

-        results = {"id": task.id, "status": task.status, "result": task.result}
-    else:
-        results = {"id": task.id, "status": task.status}
+        results = {
+            "id": task.id,
+            "status": task.status,
+            "result": task.result if task.status == "SUCCESS" else None,
+            "error": None
+        }
+    else:
+        results = {
+            "id": task.id,
+            "status": task.status,
+            "result": None,
+            "error": task.info if task.status == "FAILURE" else None
+        }

---

42-42: Add type hints to improve code clarity.

Consider adding return type hints to the async function for better code maintainability:

-async def status(task_id: str):
+async def status(task_id: str) -> dict:

Configuration used: CodeRabbit UI
Review profile: CHILL