Eas endpoints #15
Eas endpoints #15
Conversation
WalkthroughThe changes involve updates to the authentication and attestation handling within a NestJS application. Key modifications include refining exception handling in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EasController
participant EasService
participant LitService
User->>EasController: POST /:uid/decrypt-attestation-secret
EasController->>EasService: decryptSecret(decryptAttestationSecretDto)
EasService->>LitService: decryptFromJson()
LitService->>EasService: return decrypted secret
EasService-->>EasController: return secret to controller
EasController-->>User: return decrypted secret
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- src/auth/auth.service.spec.ts (2 hunks)
- src/auth/auth.service.ts (2 hunks)
- src/eas/dto/decrypt-attestation-secret.dto.ts (1 hunks)
- src/eas/eas.controller.ts (2 hunks)
- src/eas/eas.service.ts (5 hunks)
- src/lit/lit.service.ts (3 hunks)
Additional comments not posted (14)
src/eas/dto/decrypt-attestation-secret.dto.ts (2)
7-16: LGTM!The
siweJwtproperty is correctly decorated for validation and API documentation.The code changes are approved.
17-24: LGTM!The
chainIdproperty is correctly decorated for validation and API documentation.The code changes are approved.
src/auth/auth.service.ts (2)
1-1: LGTM!The import statement is correctly updated to reflect the new exception type.
The code changes are approved.
33-33: LGTM!The exception type is correctly updated to
UnauthorizedException, improving the clarity of error handling.The code changes are approved.
src/auth/auth.service.spec.ts (2)
10-10: LGTM!The import statement is correctly updated to reflect the new exception type.
The code changes are approved.
85-85: LGTM!The test case is correctly updated to expect an
UnauthorizedException, aligning with the updated behavior of theAuthService.The code changes are approved.
src/eas/eas.controller.ts (2)
65-83: LGTM! But correct the spelling ofgetAttestaion.The change to use
@Param('uid') uid: stringimproves clarity and type safety. The function is correctly implemented. However, the spelling ofgetAttestaionshould be corrected togetAttestation.Apply this diff to correct the spelling:
- const attestation = await this.easService.getAttestaion(chainId, uid) + const attestation = await this.easService.getAttestation(chainId, uid)The code changes are approved.
92-118: LGTM! But correct the spelling ofdecodettestationData.The function is correctly implemented. However, the spelling of
decodettestationDatashould be corrected todecodeAttestationData.Apply this diff to correct the spelling:
- const decodedData = this.easService.decodettestationData( + const decodedData = this.easService.decodeAttestationData(The code changes are approved.
src/eas/eas.service.ts (4)
Line range hint
74-78: LGTM!The change to make the function public is appropriate if it needs to be accessed outside the class. The function is correctly implemented.
The code changes are approved.
83-86: LGTM! But correct the spelling ofdecodettestationData.The function is correctly implemented. However, the spelling of
decodettestationDatashould be corrected todecodeAttestationData.Apply this diff to correct the spelling:
- decodettestationData(data: string): SchemaDecodedItem[] { + decodeAttestationData(data: string): SchemaDecodedItem[] {The code changes are approved.
Line range hint
105-113: LGTM! But correct the spelling ofattesation.The function is correctly implemented. However, the spelling of
attesationshould be corrected toattestation.Apply this diff to correct the spelling:
- `We aren't attester of this attesation` + `We aren't attester of this attestation`The code changes are approved.
115-118: LGTM! But correct the spelling ofattesation.The function is correctly implemented. However, the spelling of
attesationshould be corrected toattestation.Apply this diff to correct the spelling:
- `You aren't recipient of this attesation` + `You aren't recipient of this attestation`The code changes are approved.
src/lit/lit.service.ts (2)
147-149: LGTM!The change to update the
keyproperty from an empty string to'isMember'likely indicates a shift in the criteria used for evaluating membership status. The function is correctly implemented.The code changes are approved.
239-241: LGTM!The change to move the call to
getSessionSigsViaAuthSig(chainId)below the check forthis.litNodeClientensures that the connection is established before attempting to retrieve session signatures. The function is correctly implemented.The code changes are approved.
Summary by CodeRabbit
New Features
EasServicewith new methods for data encoding and recipient validation.Bug Fixes
Documentation
Refactor
EasController.