cleanup: Remove useless if clause #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
the
cleanup
JFreegman
force-pushed
the
redundant_clause
branch
2 times, most recently
from
f5e6dc3
to
5857c13
Compare
JFreegman
force-pushed
the
redundant_clause
branch
from
5857c13
to
7c49ea5
Compare
|
Are you sure you want to make (even possibly no-op) logic changes in the current release? |
Nope, we can move it to the next release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2717 +/- ##
==========================================
- Coverage 73.04% 73.03% -0.01%
==========================================
Files 149 149
Lines 30533 30531 -2
==========================================
- Hits 22302 22298 -4
- Misses 8231 8233 +2 ☔ View full report in Codecov by Sentry. |
|
Converted it to a draft to prevent an accidental auto-merge by someone reviewing it. |
JFreegman
force-pushed
the
redundant_clause
branch
2 times, most recently
from
4c09a42
to
78f6332
Compare
JFreegman
force-pushed
the
redundant_clause
branch
from
78f6332
to
de167dd
Compare
iphydf
approved these changes
Mar 28, 2024
JFreegman
force-pushed
the
redundant_clause
branch
from
de167dd
to
fa20168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is