-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(toxav): fix docs of toxav.h #2754
base: master
Are you sure you want to change the base?
Conversation
- fix units to be correct - use width before height consistently - video -> audio typo
fe5ab46
to
85d1761
Compare
acutally "b" (lowercase b) always means bits. |
and video bitrate is correct as Kb/s (kilo bits per second). well i am still checking this. its been a long time. hold on a bit ... |
zoff is right, Kb and kbit are the same unit, so that particular unit is not really being fixed, just reworded. I do support the change though, being more explicit/clear in the documentation and spelling it out is probably a good thing. |
@zoff99 yea we multiply both audio and video rates by 1000, BUT /*!\brief Target data rate
*
* Target bitrate to use for this stream, in kilobits per second.
*/
unsigned int rc_target_bitrate; |
yeah thats why i say im still checking. in my forks i think its correct but let me actually check ... |
yeah its wrong in toktok: Line 420 in 5344d7f
but fixed in mine: cfg2.rc_target_bitrate = (bit_rate / 1000); |
sidenote: opus changed, and the new meaningful lower bound for the bitrate is |
but in any case the toxav PR needs to be merged first. fixes of old bugs come only afterwards. |
@zoff99 do we preserve behavoir and adjust the comments (this pr as-is) or do we fix it and change behavior? |
This pr has no conflicts with your pr, so that does not really matter, only if we change the code. Also, someone needs to fix circle ci first ... |
back to draft, until either toxav prs is merged. |
1c68998
to
85d1761
Compare
Kb/sec
->kbit/sec
and fix video being actuallyMbit/sec
!)width
beforeheight
consistentlyThis change is