Skip to content

Commit

Permalink
Update test comments
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
  • Loading branch information
Tom-Newton committed Jan 17, 2024
1 parent 6c5650c commit 2cea075
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/workflow/executor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@ func TestWorkflowExecutor_HandleFlyteWorkflow_Failing(t *testing.T) {
h := &nodemocks.NodeHandler{}
h.OnAbortMatch(mock.Anything, mock.Anything, mock.Anything).Return(nil)

// Mock handler marks start-node successfully completed but other nodes as failed
startNodeMatcher := mock.MatchedBy(func(nodeExecContext fakeNodeExecContext) bool {
return nodeExecContext.Node().IsStartNode()
})
Expand Down Expand Up @@ -570,7 +571,6 @@ func TestWorkflowExecutor_HandleFlyteWorkflow_Failing(t *testing.T) {
WorkflowSpec: &v1alpha1.WorkflowSpec{OnFailurePolicy: test.onFailurePolicy},
}
if assert.NoError(t, json.Unmarshal(wJSON, w)) {
// For benchmark workflow, we will run into the first failure on round 6

for i := 0; i < test.expectedRoundsToFail; i++ {
t.Run(fmt.Sprintf("Round[%d]", i), func(t *testing.T) {
Expand Down

0 comments on commit 2cea075

Please sign in to comment.