Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tomnewton/dashboard updates #4

Draft
wants to merge 705 commits into
base: master
Choose a base branch
from
Draft

Tomnewton/dashboard updates #4

wants to merge 705 commits into from

Conversation

Tom-Newton
Copy link
Owner

Tracking issue

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

@Tom-Newton Tom-Newton changed the base branch from master to tomnewton/collapse_sub_nodes_on_failures November 22, 2023 22:51
@Tom-Newton Tom-Newton changed the base branch from tomnewton/collapse_sub_nodes_on_failures to master November 22, 2023 22:51
wild-endeavor and others added 27 commits February 27, 2024 15:23
@wild-endeavor
Update launch condition column (flyteorg#4903)
2b709f1 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@hamersaw
not setting IsParent on ArrayNode unless new eventing scheme (flyteor…
eaac04d 
…g#4967)

Signed-off-by: Daniel Rammer <daniel@union.ai>
@neverett
Add failure node example from flytesnacks flyteorg#1328 (flyteorg#4958)
d0d1b7f 
* add failure node example from flyteorg/flytesnacks#1328

Signed-off-by: nikki everett <nikki@union.ai>

* fix formatting and index toc

Signed-off-by: nikki everett <nikki@union.ai>

* copy edits

Signed-off-by: nikki everett <nikki@union.ai>

---------

Signed-off-by: nikki everett <nikki@union.ai>
@pingsutw @neverett @Future-Outlier
[DOC] Update agent API (flyteorg#4943)
971c5ad 
* [DOC] Update agnet API

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* nit

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* nit

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* Apply suggestions from code review

Co-authored-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Nikki Everett <neverett@users.noreply.github.com>

---------

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: nikki everett <nikki@union.ai>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Co-authored-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: nikki everett <nikki@union.ai>
@wild-endeavor @eapolinario
add mux option for application/json (flyteorg#4976)
e1d5a7a 
* add mux option for application/json

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Emit unpopulated and default values

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add comment

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@MortalHappiness
docs(troubleshooting): Add spark task execution troubleshooting (flyt…
2cc9169 
…eorg#4974)

When executing spark test, if the spark plugin enabled in the config
file, then it will show 'JavaPackage' object is not callable error.
Which is difficult to know from this error message, so add it to the
troubleshooting guide.

Resolves: flyteorg#4826

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@wild-endeavor
also run dep update (flyteorg#4977)
1caa754 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@flyte-bot @wild-endeavor
Update Flyte components (flyteorg#4980)
a2a63eb 
Signed-off-by: Flyte-Bot <admin@flyte.org>

---------

Signed-off-by: Flyte-Bot <admin@flyte.org>
Co-authored-by: wild-endeavor <wild-endeavor@users.noreply.github.com>
@pvditt
add cacheservice to idl defintions (flyteorg#4978)
33265b9 
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
@lowc1012
[BUG] Invalid "resources" scope in clusterresourcesync/deployment.yaml (
2256c2b 
flyteorg#4916)

* fix invalid clusterresourcesync/deployment.yaml

Signed-off-by: Ryan Lo <wenchih@apache.org>

* update README.md

Signed-off-by: Ryan Lo <wenchih@apache.org>

* update generated yaml files

Signed-off-by: Ryan Lo <wenchih@apache.org>

* fix typo

Signed-off-by: Ryan Lo <wenchih@apache.org>

---------

Signed-off-by: Ryan Lo <wenchih@apache.org>
@MortalHappiness
docs: Remove redundant dollar signs (flyteorg#4964)
a946070 
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@novahow
add hostname to input (flyteorg#4939)
cf21877 
Signed-off-by: novahow <b08902047@ntu.edu.tw>
@neverett
update links for monodocs (flyteorg#465)
007a4b1 
Signed-off-by: nikki everett <nikki@union.ai>
@pingsutw
Fix Monodocs build (flyteorg#5000)
4a95abf 
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@katrogan
Allow specifying flyte pod webhook deployment resources (flyteorg#4988)
caed584
@eapolinario
Pin helmdocs to 1.12.0 (flyteorg#4995)
4270c53 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@pingsutw
Specify builder for docker build (flyteorg#5002)
2adaf61 
* Specify builder for docker build

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* nit

Signed-off-by: Kevin Su <pingsutw@gmail.com>

---------

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@squiishyy
Time partition granularity (flyteorg#4959)
7be904a 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@neverett
add links to contributing guide and code (flyteorg#5006)
da20f70 
Signed-off-by: nikki everett <nikki@union.ai>
@neverett
update link to flytesnacks repo (flyteorg#5007)
f9c1a97 
Signed-off-by: nikki everett <nikki@union.ai>
@pingsutw
Improve the error message for databricks plugins (flyteorg#4477)
99dad35 
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@flyte-bot
Update Flyte components (flyteorg#5008)
610830c 
Signed-off-by: Flyte-Bot <admin@flyte.org>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@Future-Outlier @neverett
[Docs] Chatgpt Agent Setup (flyteorg#4992)
ba59258 
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
@neverett
Add Airflow migration guide (flyteorg#4871)
bce9b6f 
* move @pingsutw airflow migration doc from flytesnacks branch to flyte

Signed-off-by: nikki everett <nikki@union.ai>

* copy edits

Signed-off-by: nikki everett <nikki@union.ai>

* more copy edits

Signed-off-by: nikki everett <nikki@union.ai>

* move airflow migration guide to development lifecycle section

Signed-off-by: nikki everett <nikki@union.ai>

* copy changes from  docs/migration-guides-ping

Signed-off-by: nikki everett <nikki@union.ai>

---------

Signed-off-by: nikki everett <nikki@union.ai>
@neverett @pingsutw
Add Docker image build and FlyteAgent update steps to "Developing age…
fd42f65 
…nts" doc (flyteorg#5009)

* add docker image build and flyteagent update steps

Signed-off-by: nikki everett <nikki@union.ai>

* fix link

Signed-off-by: nikki everett <nikki@union.ai>

* remove old agents doc and redirect to new agents guide

Signed-off-by: nikki everett <nikki@union.ai>

* update timeout

Signed-off-by: Kevin Su <pingsutw@gmail.com>

---------

Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
@neverett @pingsutw
Update docs links in /flyteidl (flyteorg#4989)
f448a03 
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
@davidmirror-ops
Fix minio config on helpers.tpl (flyteorg#5018)
b710ca4 
* Fix sandbox endpoint

Signed-off-by: davidmirror-ops <david espejo@union.ai>

* Make Helm

Signed-off-by: davidmirror-ops <david espejo@union.ai>

---------

Signed-off-by: davidmirror-ops <david espejo@union.ai>
Co-authored-by: davidmirror-ops <david espejo@union.ai>
@Tom-Newton
Fix Y axis labels
78a92e2 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Check-in latest dashboard
071ca91 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add garbage collection stats
103e053 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Fix scale on cache hit rate
5180e65 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Working flytepropeller grpc histograms
5f0aa76 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Change to a single accumulated graph
47b4c73 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add GRPC histogram on flyteadmin too
547057d 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Fix admin metrics name
0efd55a 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Update workqueue metric names for flyte 1.11.0
34a6d35 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add other queues to queue graphs
5d02c9f 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add round success counter, remove workqueue latencies
65db5fc 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Split enqueues by type and add missing rate for skip rate metric
f7610ef 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Don't use rate for round latency graphs
52e3a36 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Fix metric name for plugin failures and make it a rate
a44e788 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Fix duplicate refIds
7116a3f 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Fix typo
6222ad9 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Update lots of title and units
1ce7f3c 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add round errors graph
57ff180 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add total round rate
2766041 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Group metrics onto the same graphs were relevant
53dce4f 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Small updates
22a5914 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Fix streaks graph
5965cf7 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
rename legend
73e2230 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Rename
802b7ba 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add descriptions
2003d7c 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Add a missing title
da613c9 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Remove unused imports
6d1f00d 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
Adjust a description
d9076ab 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton
More minor updates
5af4a10 
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton Tom-Newton force-pushed the tomnewton/dashboard_updates branch from c35d80a to 5af4a10 Compare May 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.