Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydro submodule for creating populations from hydrodynamical zoom-in simulations #96

Merged
merged 46 commits into from
Jan 16, 2024

Conversation

TomWagg
Copy link
Owner

@TomWagg TomWagg commented Jan 15, 2024

Rather a large PR here. Copying from the docs:

The hydro module contains the functionality necessary for running simulations that use hydrodynamical
zoom-in simulations as their initial conditions. This includes the ability to read in snapshots,
centre and rotate them, estimate the galactic potential, get the initial conditions of star particles and
run a full cogsworth Population based on all that!

Tutorials and tests are still to come but it seems to work for now! This will fix #92 and will fix #93.

The _tohspans function is my personal favourite addition 😜

@TomWagg TomWagg added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 15, 2024
@TomWagg TomWagg self-assigned this Jan 15, 2024
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1434 1310 91% 0% 🟢

New Files

File Coverage Status
cogsworth/hydro/init.py 100% 🟢
cogsworth/hydro/pop.py 17% 🟢
cogsworth/hydro/potential.py 29% 🟢
cogsworth/hydro/rewind.py 29% 🟢
cogsworth/hydro/test.py 0% 🟢
cogsworth/hydro/utils.py 40% 🟢
TOTAL 36% 🟢

Modified Files

File Coverage Status
cogsworth/citations.py 100% 🟢
cogsworth/pop.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 265680c by action🐍

@TomWagg TomWagg merged commit dd8f423 into main Jan 16, 2024
2 checks passed
@TomWagg TomWagg deleted the hydro branch January 16, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the new hydro submodules Properly allow FIRE/ChaNGa as initial conditions for cogsworth pops
1 participant