Compare class-names case insensitive

[staabm]

No description provided.

[TomasVotruba]

Thanks! 😊

Could you add simple test so we don't remove it in the future?

[staabm]

here we go :)

[staabm]

@TomasVotruba should be good to go

[TomasVotruba]

I'd prefer to include this test as a single test fixture in the rule itselft, instead of adding a new unit test.
It would be easier to read for me later.

[staabm]

the class is used at the top level CheckCommand which means I would need to test at the command level.. with all its dependencies?
are you sure we want that ? :)

class-leak/src/Commands/CheckCommand.php

Lines 113 to 119 in 2fc838e

	$possiblyUnusedFilesWithClasses = $this->possiblyUnusedClassesFilter->filter(
	$existingFilesWithClasses,
	$usedNames,
	$typesToSkip,
	$suffixesToSkip,
	$attributesToSkip
	);

[TomasVotruba]

I see. What I really want is the test to be simpler, as reading is quite complex now :)

[TomasVotruba]

On other hand, we should not encourage using wrong class casing. This should be spotted and trigger the class name fix instead.

[staabm]

phpstan itself does already error about class-name-case-mismatches. I think its not the job of class-leak to report it as a problem

[TomasVotruba]

Exactly, this tool builds on top of PHPStan best quality code. Let PHPStan handle these 👍

[TomasVotruba]

Closing as outsourcing responsibility to PHPStan 👍