Detect constants only used in tests

src/Collectors/ClassConstFetchCollector.php

@@ -11,6 +11,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Collectors\Collector;
 use PHPStan\Reflection\ClassReflection;
+use TomasVotruba\UnusedPublic\ClassTypeDetector;
 use TomasVotruba\UnusedPublic\Configuration;
 
 /**
@@ -19,7 +20,8 @@
 final class ClassConstFetchCollector implements Collector
 {
     public function __construct(
-        private readonly Configuration $configuration
+        private readonly Configuration $configuration,
+        private readonly ClassTypeDetector $classTypeDetector,
     ) {
     }
 
@@ -50,14 +52,20 @@ public function processNode(Node $node, Scope $scope): ?array
         $constantName = $node->name->toString();
 
         $classReflection = $scope->getClassReflection();
-        if ($classReflection instanceof ClassReflection && $classReflection->hasConstant($constantName)) {
-            $constantReflection = $classReflection->getConstant($constantName);
-            $declaringClass = $constantReflection->getDeclaringClass();
-            if ($declaringClass->getFileName() !== $classReflection->getFileName()) {
-                return [$declaringClass->getName() . '::' . $constantName];
+        if ($classReflection instanceof ClassReflection) {
+            if ($this->classTypeDetector->isTestClass($classReflection)) {
+                return null;
             }
 
-            return null;
+            if ($classReflection->hasConstant($constantName)) {
+                $constantReflection = $classReflection->getConstant($constantName);
+                $declaringClass = $constantReflection->getDeclaringClass();
+                if ($declaringClass->getFileName() !== $classReflection->getFileName()) {
+                    return [$declaringClass->getName() . '::' . $constantName];
+                }
+
+                return null;
+            }
         }
 
         return [$className . '::' . $constantName];

src/Rules/LocalOnlyPublicClassMethodRule.php

@@ -30,6 +30,8 @@ final class LocalOnlyPublicClassMethodRule implements Rule
 {
     /**
      * @var string
+     *
+     * @api
      */
     public const ERROR_MESSAGE = 'Public method "%s::%s()" is used only locally and should be turned protected/private';
 

src/Rules/UnusedPublicClassConstRule.php

@@ -25,6 +25,8 @@ final class UnusedPublicClassConstRule implements Rule
 {
     /**
      * @var string
+     *
+     * @api
      */
     public const ERROR_MESSAGE = 'Public constant "%s::%s" is never used';
 

src/Rules/UnusedPublicClassMethodRule.php

@@ -32,6 +32,8 @@ final class UnusedPublicClassMethodRule implements Rule
 {
     /**
      * @var string
+     *
+     * @api
      */
     public const ERROR_MESSAGE = 'Public method "%s::%s()" is never used';
 

src/Rules/UnusedPublicPropertyRule.php

@@ -24,6 +24,8 @@ final class UnusedPublicPropertyRule implements Rule
 {
     /**
      * @var string
+     *
+     * @api
      */
     public const ERROR_MESSAGE = 'Public property "%s::$%s" is never used';
 

tests/Rules/UnusedPublicClassConstRule/Fixture/UsedInTestCaseOnly.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassConstRule\Fixture;
+
+final class UsedInTestCaseOnly
+{
+    public const USE_ME = 'not here';
+}

tests/Rules/UnusedPublicClassConstRule/Source/TestCaseUser.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassConstRule\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class TestCaseUser extends TestCase
+{
+    private function go()
+    {
+        $used = UsedInTestCaseOnly::USE_ME;
+    }
+}

tests/Rules/UnusedPublicClassConstRule/UnusedPublicClassConstRuleTest.php

@@ -13,10 +13,12 @@
 use TomasVotruba\UnusedPublic\Collectors\PublicClassLikeConstCollector;
 use TomasVotruba\UnusedPublic\Enum\RuleTips;
 use TomasVotruba\UnusedPublic\Rules\UnusedPublicClassConstRule;
+use TomasVotruba\UnusedPublic\Rules\UnusedPublicClassMethodRule;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassConstRule\Fixture\LocallyUsedPublicConstant;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassConstRule\Fixture\LocallyUsedPublicConstantByName;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassConstRule\Fixture\UnusedPublicConstant;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassConstRule\Fixture\UnusedPublicConstantFromInterface;
+use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicClassMethodRule\Fixture\UsedInTestCaseOnly;
 
 final class UnusedPublicClassConstRuleTest extends RuleTestCase
 {
@@ -74,6 +76,13 @@ public static function provideData(): Iterator
         ];
 
         yield [[__DIR__ . '/Fixture/SkipInterfaceConstantUsed.php', __DIR__ . '/Source/InterfaceConstantUser.php'], []];
+
+        $errorMessage = sprintf(UnusedPublicClassConstRule::ERROR_MESSAGE, Fixture\UsedInTestCaseOnly::class, 'USE_ME');
+        yield [[
+            __DIR__ . '/Fixture/UsedInTestCaseOnly.php',
+            __DIR__ . '/Source/TestCaseUser.php',
+        ], [[$errorMessage, 9, RuleTips::SOLUTION_MESSAGE]]];
+
     }
 
     /**