Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #74

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Linting #74

merged 1 commit into from
Oct 1, 2024

Conversation

hwangsihu
Copy link
Contributor

No description provided.

Copy link

pkg-pr-new bot commented Sep 27, 2024

Open in Stackblitz

bun add https://pkg.pr.new/Tomato6966/lavalink-client@74

commit: 1329d07

@Tomato6966
Copy link
Owner

As stated in 3 other PRs, i am handling the versioning of dependencies but this commit looks good, i will check it out when im on my pc again

@Tomato6966
Copy link
Owner

Please remove the changes to all package.json, then i can merge the change regarding the types

@hwangsihu hwangsihu changed the title Update all packages and linting Linting Sep 30, 2024
@Tomato6966
Copy link
Owner

Thanks!

@Tomato6966 Tomato6966 merged commit ca317d0 into Tomato6966:main Oct 1, 2024
2 checks passed
@hwangsihu
Copy link
Contributor Author

Sorry to ask here, but why do you want to manage your package only with dependabot? Looking at the PR, it looks like dependabot won't submit the PR even though have a newer version.

@Tomato6966
Copy link
Owner

I manage it manually, whenever i release smt, i don't want to release a new version just because of a dependency update, i connected dependabot to retrieve notifications for vulnarabilities in case some happen

@hwangsihu
Copy link
Contributor Author

If you don't want to release a new version because of the package, you can just not release it and release it when new features come out
Anyway, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants