Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anisotropic regularization for FILD measurements showcaseAdd notebook with external file references and LICENSE #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bosschmidt
Copy link

@bosschmidt bosschmidt commented Oct 31, 2024

Describe your contribution

CIL user showcase 13

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have created a new folder, containing my contributions which are in the form of jupyter notebooks, with any necessary supporting python files, and a LICENSE file.
  • I have added a description of my contribution(s) to the top of my file(s)
  • If publicly available, I have added a link to the dataset used near the top of my file(s)
  • I have added the CIL version I ran with near the top of my file(s)
  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL-User-Showcase.
  • I confirm that the contribution does not violate any intellectual property rights of third parties.
  • I confirm that I have added license headers to all of the files I am contributing (with a license of my choice)
  • Change pull request label to 'Waiting for review'

Note: for an example of a contribution, where a license header, description, data link and CIL version has been added, please
see: example_contribution

@MargaretDuff
Copy link
Member

Thanks @bosschmidt - looking forward to seeing you next week! We will take a look at this, probably after the user meeting

@MargaretDuff
Copy link
Member

Hi @bosschmidt! Thanks again for your submission and good to see you at the user meeting last week.

I have just taken a quick look. The notebook lists a set of custom files needed to run the notebook:

  • my_custom_operator.py: Custom FILD operator implementation
  • manolo_colormap.py: Custom colormap for visualization
  • WaveletOperator.py: CIL's wavelet transform implementation
  • b_2D.npy: Experimental FILD data
  • 34614_Bo_v2023_4_weight_function.nc: Simulated system matrix

It is nice if these notebooks can be run by the user but understand if data cannot be shared. It especially would be good to share the "my_custom_operator.py" file, so people can see the custom CIL operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

2 participants