refactor(skills): consolidate git into github, rename init-review to review (LISA-19, LISA-33)#210
Conversation
…review (LISA-19) - Merge git skill content (CI triggers, version bumping, workflows) into github skill - Move bump-version.ts from skills/git/ to skills/github/ - Add customizable pr-description-template.txt for PR body generation - Rename init-review skill to review across all paths and references - Update deploy script, init command, and CLAUDE.md skill table - Add pr skill to symlink lists for claude and opencode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughReplaces Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI (bump-version)
participant Env as Env Loader
participant Service as VersionService
participant Repo as Git Repo
CLI->>Env: load LISA_AUTO_BUMP_VERSION, other env
Env-->>CLI: env values
CLI->>Service: createVersionService()
CLI->>Service: validateBumpType(bumpType)
Service-->>CLI: validation result
CLI->>Service: bump(bumpType)
Service->>Repo: update version tag/files & commit
Repo-->>Service: result (new version)
Service-->>CLI: bump result
CLI->>CLI: print JSON result / exit
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/project/.lisa/skills/review/SKILL.md (1)
106-108: 🧹 Nitpick | 🔵 TrivialMarker file path references legacy naming.
The marker file
.lisa/.init-review-doneand log file.init-review.log(line 118) retain the old naming. If backward compatibility with existing installations is required, this is acceptable. Otherwise, consider updating these to.review-doneand.review.logfor consistency.
🤖 Fix all issues with AI agents
In `@src/project/.lisa/skills/github/SKILL.md`:
- Around line 424-434: Update the CircleCI examples in SKILL.md to stop relying
on the fragile "$(cat ~/.circleci/cli.yml | grep token | awk '{print $2}')"
pattern: add a prerequisite note describing the expected CircleCI CLI YAML
format, provide a recommended alternative using the $CIRCLE_TOKEN environment
variable, and replace the extraction example with a more robust form using "grep
token ~/.circleci/cli.yml 2>/dev/null | awk '{print $2}'" (or mention other
parsing options) plus a brief error-handling note that the file may be missing
or malformed and how to fall back to $CIRCLE_TOKEN; ensure the doc references
the two example blocks for "Get latest pipeline for a branch" and "Get workflow
status for a pipeline" so both curl commands are updated.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@src/project/.lisa/skills/github/SKILL.md`:
- Around line 492-507: The headings "## Cross-model checklist", "## Notes", and
"## See Also" are missing surrounding blank lines; update the SKILL.md content
so each of these heading lines has a blank line immediately before and after
them (i.e., insert one empty line above and one empty line below each of "##
Cross-model checklist", "## Notes", and "## See Also") to satisfy markdownlint
MD022 and preserve existing paragraph content and list formatting.
- Around line 448-491: The numbered workflow steps under the "Workflow: Push
with Version Bump" and "Workflow: PR Test Failure" sections contain fenced code
blocks that lack surrounding blank lines (MD031); edit the SKILL.md content so
each fenced block (the ```bash blocks in the "Bump version", "Commit the version
bump", "Push to remote" steps and the multi-line gh pr edit block in "Retrigger
tests") has a blank line both immediately before and immediately after the
fenced block, preserving existing indentation and wording.
- Around line 402-447: The "Git Workflows" section has Markdownlint errors
MD022/MD031 because headings (e.g., "Check PR Status", "Retrigger CI Tests",
"Check CircleCI Pipeline Status", "Poll CI Until Completion") and the fenced
code blocks (triple-backtick blocks showing bash commands) are not separated by
blank lines; fix by adding a single blank line before and after each heading and
before and after each fenced code block (the ```bash blocks) so every heading
and fenced block is surrounded by an empty line.
…SION env (LISA-33) Add LISA_AUTO_BUMP_VERSION setting to .lisa/.env that controls whether version bumping runs: true (default), false (skip), or a bump type (patch/minor/major) to set the default. CLI args always override. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TonyCasey
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/unit/src/lib/skills/git/bump-version.test.ts`:
- Around line 16-17: Move the bump-version.test.ts test into the github skill
directory under tests/unit/src/lib/skills (so the tests mirror the src/lib
hierarchy) and update the file name/location accordingly; inside the test update
the SCRIPT_PATH constant and any import/reference that still points to the old
"git" location to reference the compiled bump-version.js under the github skill
(i.e., ensure SCRIPT_PATH and any require/imports reference the github path) so
the unit test structure matches the source structure and all references resolve.
- Move bump-version.test.ts from skills/git/ to skills/github/ to mirror source structure - Fix markdownlint MD022/MD031: add blank lines around headings and fenced code blocks in SKILL.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add git-rules.md, git-rules.local.md, memory-rules.md, task-rules.md to rules scaffolding in init command - Allow .txt and .json files through skills copy filter so pr-description-template.txt is included - Update package.json exports for renamed skill paths (git -> github, init-review -> review) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…A-19) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitskill into thegithubskill so there's a single unified skill for all Git/GitHub operationsinit-reviewtoreview— cleaner, shorter skill namepr-description-template.txtfor end usersLISA_AUTO_BUMP_VERSIONenv var in.lisa/.envto disable or configure default bump typeTest plan
npm test)npm run lint)npm run build)LISA_AUTO_BUMP_VERSIONbehavior (false/skip, env default, CLI override, unrecognized value)/github,/review)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Refactor
/gitand/init-reviewreplaced with/github,/review, and/prDocumentation
Tests