Skip to content

fix(http-proxy-agent): add support for raw header format #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smckee-r7 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix(http-proxy-agent): add support for raw header format #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/http-proxy-agent/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,18 @@ export class HttpProxyAgent<Uri extends string> extends Agent {
): void {
const { proxy } = this;
const protocol = opts.secureEndpoint ? 'https:' : 'http:';
const hostname = req.getHeader('host') || 'localhost';

let hostname = req.getHeader('host');
// If host header is not set or available in the processed headers, construct it from opts.host and opts.port
if (!hostname) {
const host = opts.host || 'localhost';
const port = opts.port || '';

// Wrap IPv6 addresses in brackets for proper hostname format
const formattedHost = net.isIPv6(host) ? `[${host}]` : host;
hostname = port ? `${formattedHost}:${port}` : formattedHost;
}

const base = `${protocol}//${hostname}`;
const url = new URL(req.path, base);
if (opts.port !== 80) {
Expand Down