Notification Templates - Documentation Improvements#30
Open
Rick-Jongbloed wants to merge 16 commits intomainfrom
Open
Notification Templates - Documentation Improvements#30Rick-Jongbloed wants to merge 16 commits intomainfrom
Rick-Jongbloed wants to merge 16 commits intomainfrom
Conversation
| </mj-section> | ||
| <mj-section background-color="#4a8fca" padding-top="0" padding-bottom="0"> | ||
| <mj-column width="25%"> | ||
| <mj-image src="https://customer.helloid.training/appearance/companyicon" width="50px" height="50px"> |
Contributor
There was a problem hiding this comment.
Alle image urls bevatten nog .training i.p.v. .com
rhouthuijzen
added
needs-review
rhouthuijzen
requested changes
Mar 9, 2026
Contributor
rhouthuijzen
left a comment
rhouthuijzen
left a comment
There was a problem hiding this comment.
Na overleg met BC de volgende feedback, zou je dit nog kunnen verwerken?
- Alles behalve templates zelf in het Engels (
README.md) - Files voorbereiden op andere talen (mogelijk IA al laten maken?) Bijvoorbeeld:
templateNL.mjmlentemplateEN.mjml. - In de README van de specifieke mailtjes staat nu niet een link naar de mail zelf. Je zou verwachten een link in de README naar de
mjml file. Bijvoorbeeld MailNL: Link,Mail EN: Link .trainingvervangen door.com. Dan hoeft de gebruiker alleencustomeraan te passen
rhouthuijzen
added
pending-author-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uitgebreide verbetering van alle notification template documentatie: gestandaardiseerde structuur met volledige stap-voor-stap instructies voor importeren en configureren, correcte ontvanger variabelen (manager/medewerker/applicatiebeheer), directe links naar HelloID documentatie voor from adres/variabelen/filters, pre-offboard configuratie uitleg, en klikbare notificatie links in hoofd README. Alle templates hebben nu consistente "Gebruik" secties, AD-specifieke waarschuwingen, en duidelijke instructies voor het aanpassen van fallback e-mailadressen.