chore: add travel auction to v2 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add travel auction open api documentation to v2
LemonPy29
force-pushed
the
chore/am/travel-auction
branch
from
347f432 to
85c6590
Compare
celzo
reviewed
Jan 6, 2025
| products: | ||
| - id: hotel-1 | ||
| qualityScore: 0.7 | ||
| - id: hotel-2 |
There was a problem hiding this comment.
Aren't quality scores mandatory for all products? Or we decided to assume 1 for those that are not defined?
There was a problem hiding this comment.
yes, optional and they default to 1 internally
There was a problem hiding this comment.
they default to 1 internally
this could be great to explain in the qualityScore docs.
celzo
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add travel auction open api documentation to v2