-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to slice images and subjects #1170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenicho
approved these changes
May 13, 2024
@allcontributors please add @marius-sm for ideas |
I've put up a pull request to add @marius-sm! 🎉 |
Hi @fepegar, very nice! Sorry for not contributing more myself. I am not coding anymore at the moment. |
No worries! |
I hope you're ok with being added to the contributor list. |
Sure, thanks!
Le mer. 15 mai 2024 à 22:12, Fernando Pérez-García ***@***.***>
a écrit :
… I hope you're ok with being added to the contributor list.
—
Reply to this email directly, view it on GitHub
<#1170 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSOFBLPKJ6OYGV2HJW7MBTZCO6S7AVCNFSM6AAAAABHHHG4OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTGM3TKMBZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1011.
Description
See @marius-sm's feature request.
I would appreciate it if someone could please take a look!
@marius-sm @abenicho @wahabk @HyunKyungHan
Checklist
CONTRIBUTING
docs and have a developer setup (especially important arepre-commit
andpytest
)pytest
make html
inside thedocs/
folder