Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transform return the same type as input #1182

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

haarisr
Copy link
Contributor

@haarisr haarisr commented Jun 24, 2024

Description

Transform call currently returns a new type TypeTransformInput. This PR makes a generic type bound by the original TypeTransformInput so that type checkers know the same type is being returned.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed

@fepegar fepegar merged commit 50a1c6e into TorchIO-project:main Jun 28, 2024
14 of 15 checks passed
@fepegar
Copy link
Member

fepegar commented Jun 28, 2024

Thanks for your contribution, @haarisr!

@fepegar
Copy link
Member

fepegar commented Jun 28, 2024

@allcontributors please add @haarisr for code

Copy link
Contributor

@fepegar

I've put up a pull request to add @haarisr! 🎉

@haarisr haarisr deleted the patch1 branch June 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants