-
Notifications
You must be signed in to change notification settings - Fork 100
Method doing conversion but without conversion (TypingResult.canBeConvertedWithoutConversionTo
) removal.
#7984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
740d1d2
to
e1d226e
Compare
…nvertedWithoutConversionTo`) removal. Some additional changes: - All implicit conversion checks are now done in one place (`TypeConversionHandler`), before the change array to list conversion was checked in `MethodDefinition` - Implicit conversions are now not valid for strict conversion checking - Strict conversion check doesn't allow implicit conversions such as Int to BigDecimal or String to ZoneId - Better method names in the `TypingResult` API: `canBeAssignedTo` instead of `canBeConvertedTo`
e1d226e
to
bae9544
Compare
paw787878
reviewed
Apr 24, 2025
components-api/src/main/scala/pl/touk/nussknacker/engine/api/typed/typing.scala
Outdated
Show resolved
Hide resolved
paw787878
reviewed
Apr 24, 2025
...ts-api/src/test/scala/pl/touk/nussknacker/engine/api/typed/AssignabilityDeterminerSpec.scala
Outdated
Show resolved
Hide resolved
paw787878
reviewed
Apr 24, 2025
...ts-api/src/test/scala/pl/touk/nussknacker/engine/api/typed/AssignabilityDeterminerSpec.scala
Outdated
Show resolved
Hide resolved
LGTM |
paw787878
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lciolecki
reviewed
Apr 24, 2025
components-api/src/main/scala/pl/touk/nussknacker/engine/api/typed/typing.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional changes:
TypeConversionHandler
), before the change array to list conversion was checked inMethodDefinition
TypingResult
API:canBeAssignedTo
instead ofcanBeConvertedTo
Describe your changes
Checklist before merge