Skip to content

Method doing conversion but without conversion (TypingResult.canBeConvertedWithoutConversionTo) removal. #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2025

Conversation

arkadius
Copy link
Member

Some additional changes:

  • All implicit conversion checks are now done in one place (TypeConversionHandler), before the change array to list conversion was checked in MethodDefinition
  • Implicit conversions are now not valid for strict conversion checking
  • Strict conversion check doesn't allow implicit conversions such as Int to BigDecimal or String to ZoneId
  • Better method names in the TypingResult API: canBeAssignedTo instead of canBeConvertedTo

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius force-pushed the canBeConvertedWithoutConversionTo-fix branch 2 times, most recently from 740d1d2 to e1d226e Compare April 23, 2025 15:22
@github-actions github-actions bot added the docs label Apr 23, 2025
…nvertedWithoutConversionTo`) removal.

Some additional changes:
- All implicit conversion checks are now done in one place (`TypeConversionHandler`), before the change array to list conversion was checked in `MethodDefinition`
- Implicit conversions are now not valid for strict conversion checking
- Strict conversion check doesn't allow implicit conversions such as Int to BigDecimal or String to ZoneId
- Better method names in the `TypingResult` API: `canBeAssignedTo` instead of `canBeConvertedTo`
@paw787878
Copy link
Contributor

LGTM

Copy link
Contributor

@paw787878 paw787878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit d367d29 into staging Apr 24, 2025
5 checks passed
@arkadius arkadius deleted the canBeConvertedWithoutConversionTo-fix branch April 24, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants