Skip to content

Add Browserbase wordmark #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented May 25, 2025

Description

Add's Browserbase

Type of change

Please delete options that aren't relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Contributor

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved


web/platform/src/components/qwik/sections/hero.tsx line 3 at r1 (raw file):

import { component$, useSignal, useVisibleTask$ } from "@builder.io/qwik";
import { Background, Cloud } from "../../media/icons/icons.tsx";
import { BackgroundVideo } from "../components/video.tsx";

Let's leave this one for now. I agree that we want something like this, but we've already given the task to #1799 to help them get familiar with the codebase and our workflows.

@MarcusSorealheis MarcusSorealheis dismissed aaronmondal’s stale review June 12, 2025 19:54

no longer responding to inquiries unfortunately. I wish him all the best. He is a great person.

Copy link
Contributor

@luis-munoz luis-munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarcusSorealheis MarcusSorealheis merged commit bace8c0 into TraceMachina:main Jun 13, 2025
8 of 9 checks passed
palfrey pushed a commit to palfrey/nativelink that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants