-
Notifications
You must be signed in to change notification settings - Fork 192
Add Browserbase wordmark #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Browserbase wordmark #1800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
web/platform/src/components/qwik/sections/hero.tsx
line 3 at r1 (raw file):
import { component$, useSignal, useVisibleTask$ } from "@builder.io/qwik"; import { Background, Cloud } from "../../media/icons/icons.tsx"; import { BackgroundVideo } from "../components/video.tsx";
Let's leave this one for now. I agree that we want something like this, but we've already given the task to #1799 to help them get familiar with the codebase and our workflows.
f6905cf
to
4e2da3a
Compare
4e2da3a
to
ac39e69
Compare
no longer responding to inquiries unfortunately. I wish him all the best. He is a great person.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Add's Browserbase
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is