test: Santosh test #1
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| func (d *Decoder) SetAllowMissingFields(v bool) { | ||
| d.allowMissingFields = v | ||
| } |
There was a problem hiding this comment.
This new public API function should have documentation explaining its purpose and behavior, similar to other public methods in this file.
| if d.allowMissingFields { | ||
| d.buf = buf | ||
| return d.callEmit(HeaderField{Name: fmt.Sprintf("missing-index-%d", idx), Value: "none"}) | ||
| } |
There was a problem hiding this comment.
There's an inconsistency in how missing fields are handled. In parseFieldIndexed(), you set the value to "none", but in parseFieldLiteral(), no value is set for missing fields. Consider using a consistent approach for both cases.
There was a problem hiding this comment.
this is if complete header filed is indexed. (key and value)
For parseFieldLiteral the value is not indexed, only header key
|
@t-santoshsahu are we actively pursuing this? |
| ihf, ok := d.at(nameIdx) | ||
| if !ok { | ||
| return DecodingError{InvalidIndexError(nameIdx)} | ||
| if !d.allowMissingFields { |
There was a problem hiding this comment.
We should have some unit tests to verify this logic.
|
We should probably have a readme on how to maintain it. |
Not actively pursuing it. I will get back to it. There seems to be an issue when there is packet loss, hpack indexing can cause mismatch. |
No description provided.