attach now accepts a nullable View as it internally is used safely
#35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mapViewis treated asNullablethroughoutMapMeAdapterbut when attaching, only aNonNull Viewis accepted. Even asSupportMapFragmentis inflated in a parent'sonCreateView, upon configuration changesonMapReadymight be called beforeonCreateViewof the parent so if the attaching is done inonMapReadythe only possible validViewto pass is the one fetched byrequireView()but thatViewhas yet not been created and anIllegalExceptionwill be thrown.Instead if
getView()that isNullablewould be allowed, things would work out.