feat: add trapezoid and hexagon shapes in HVV #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor HVV bus lines to hexagon shape - refactor HVV ferry lines to trapezoid shape - fix wrong outlined shapes for HVV Xpress bus lines - add support for hexagon and trapezoid shapes in sample website Signed-off-by: The one with the braid <info@braid.business>
TheOneWithTheBraid
force-pushed
the
braid/hvv-shapes
branch
from
2b2486d to
0d6919d
Compare
Merged
marhei
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this PR adds support for the sample website, the edge case of a hexagon/trapezoid shape with border is not supported in the minimal CSS version yet since CSS clips are applied after drawing the border of elements. Since as of now I do not know any line using this edge case and there actually has been no renderer for it at all as of now, I'd consider this an acceptable regression.
About the fixed HVV Xpress bus line outline : I guess the original reporter misinterpreted the "runs occasionally" color scheme on the line map as actual line color, the PDF sheets show the correct color in opposite : https://www.hvv.de/resource/blob/73106/fa5e3bc70197d2ca4298012e60772c12/hvv_linienfahrplan_X40.pdf