Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NRW colours for 2024 #65

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Update NRW colours for 2024 #65

merged 3 commits into from
Dec 12, 2023

Conversation

metrophil
Copy link
Contributor

  • add new lines RE41, RE62 [new line RB37 could not yet be added bc it's not in Hafas yet]
  • edit operator for RE16, RB46, RB91, S7
  • fix RE57
  • fix S-Bahn colours from better source

Please only merge this on or after 10 December 2023

- add new lines RE41, RE62 [new line RB37 could not yet be added bc it's not in Hafas yet]
- edit operator for RE16, RB46, RB91, S7
- fix RE57
- fix S-Bahn colours from better source

Please only merge this on or after 10 December 2023
Update re NRW 2024 changes
@bendix-dev
Copy link

When you change the operator the line icons would disappear for old check ins. I think you should rather duplicate those line entries.

@marhei
Copy link
Contributor

marhei commented Dec 6, 2023

I don't think it's a good idea to leave outdated data in the csv. There are already conflicts between different regions with the same line names and operators, that would only increase this problem.

@marhei marhei merged commit 82cd584 into Traewelling:main Dec 12, 2023
2 checks passed
@metrophil metrophil deleted the patch-5 branch January 28, 2024 14:44
@fzakfeld
Copy link

fzakfeld commented Mar 4, 2024

I think it is a bad idea to remove styles from historical checkins. Perhaps you should add a "valid from/to" field?

There is no icon for Hamburg S11 etc anymore.

@jheubuch
Copy link
Collaborator

jheubuch commented Mar 5, 2024

I think it is a bad idea to remove styles from historical checkins. Perhaps you should add a "valid from/to" field?

There is no icon for Hamburg S11 etc anymore.

As this is not a collection of line icons just for Träwelling check-ins (it should be a generally usable dataset), I don't think that it is useful to collect historical data.

Nevertheless please use Discussions or Issues for topics like that. A merged merge request is not the right place to discuss specification changes 😅

@Traewelling Traewelling locked as off-topic and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants