Reorder sources.json and line-colors.csv #84
Conversation
...and shortened three shortOperatorNames I previously submitted myself
Sort list strictly alphanumeric (shortOperatorCode and lineName). Additonally shortened three shortOperatorNames.
| @@ -53,24 +53,24 @@ db-regio-nordost,RE66,db-regio-ag-nordost,re-66,#007734,#ffffff,,rectangle | |||
| db-regio-nordost,RE7,db-regio-ag-nordost,re-7,#007734,#ffffff,,rectangle | |||
| db-regio-sudost,RE14,db-regio-ag-sudost,re-14,#a98956,#ffffff,,rectangle | |||
| db-regio-sudost,S1,db-regio-ag-sudost,4-800486-1,#f5de2b,#000000,,pill | |||
| db-regio-sudost,S10,db-regio-ag-sudost,4-800486-10,#ffffff,#000000,#f5de2b,pill | |||
There was a problem hiding this comment.
10 after 1? Yes, I know it's technically correct, but it feels wrong.
For some regions and lines it's fine because line S47 is a shorter or slightly modified version of line S4, but line S10 is probably just the next line after S9 and not a variant of line S1. I'm really not sure if this is the best way to order line numbers...
There was a problem hiding this comment.
I agree, the numbers should be sorted numerically.
There was a problem hiding this comment.
The sorting in its current state is absolutely inconsistent and varies between different parts of the dataset. In my opinion this should be fixed. As the technically correct way of sorting doen't seem to be preferred here, I'd like to know how to proceed.
marhei
added
the
needs-discussion
The sorting in line-colors.csv is now strictly alphanumeric for shortOperatorName and lineName. The sorting in sources.json is now strictly alphanumeric for shortOperatorName.
Additonally I did the following very small changes:
db-regionetz-westfrankenbahn --> db-wfb
regio-s-bahn-donau-iller --> rsb-di
sweg-stuttgart --> sweg
sweg-sudwest --> sweg