🐛 Catch error when wrong datatype is given in request (#507)

app/Http/Controllers/FrontendStatusController.php

@@ -58,14 +58,22 @@ public function getGlobalDashboard(): Renderable {
         ]);
     }
 
+    /**
+     * @param Request $request
+     * @todo Is this api? Because of JsonReponse. But if yes: Why it does an Redirect?
+     * @return JsonResponse|RedirectResponse
+     */
     public function DeleteStatus(Request $request): JsonResponse|RedirectResponse {
         try {
-            StatusBackend::DeleteStatus(Auth::user(), $request['statusId']);
+            if(!is_numeric($request['statusId'])) {
+                return redirect()->back()->with('error', __('error.bad-request'));
+            }
+            StatusBackend::DeleteStatus(Auth::user(), (int)$request['statusId']);
         } catch (PermissionException | ModelNotFoundException) {
             return redirect()->back()->with('error', __('controller.status.not-permitted'));
         }
 
-        return response()->json(['message' => __('controller.status.delete-ok')], 200);
+        return response()->json(['message' => __('controller.status.delete-ok')]);
     }
 
     public function EditStatus(Request $request): JsonResponse|RedirectResponse {

resources/lang/de.json

@@ -119,6 +119,7 @@
     "dates.Wednesday": "Mittwoch",
     "dateformat.with-weekday": "dddd, DD. MMMM YYYY",
     "dateformat.month-and-year": "MMMM YYYY",
+    "error.bad-request": "Die Anfrage ist ungültig.",
     "events.header": "Veranstaltung: :name",
     "events.name": "Name",
     "events.hashtag": "Hashtag",

resources/lang/en.json

@@ -95,6 +95,7 @@
     "controller.user.follow-request-ok": "Requested follow.",
     "controller.user.password-changed-ok": "Password changed.",
     "controller.user.password-wrong": "Password wrong.",
+    "error.bad-request": "The request is invalid.",
     "dates.-on-": " on ",
     "dates.decimal_point": ".",
     "dates.thousands_sep": ",",