Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout param #194

Merged
merged 8 commits into from
Aug 2, 2024
Merged

feat: add timeout param #194

merged 8 commits into from
Aug 2, 2024

Conversation

tribiec
Copy link
Contributor

@tribiec tribiec commented Jul 30, 2024

This pull request adds the option to pass a timeout parameter to the Options object. The timeout parameter is an optional integer. It sets the maximum time allowed to generate a timeout when making a request.

Evidence

Grabacion.de.pantalla.2024-07-30.a.las.9.26.37.a.m.mov

Exception Message

Captura de pantalla 2024-08-01 a las 3 56 21 p m

Co-authored-by: Mauricio Astudillo <m.astudillo.toledo@gmail.com>
Copy link

sonarcloud bot commented Jul 30, 2024

@mastudillot mastudillot self-requested a review July 31, 2024 19:47
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 💪

@mastudillot mastudillot merged commit 650f8d0 into develop Aug 2, 2024
5 checks passed
@mastudillot mastudillot deleted the feat/add-timeout-param branch August 2, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants