Terminal for workbench #80
Conversation
… where websocket connections gets terminated by client
| github.com/gin-gonic/gin v1.10.0 | ||
| github.com/go-git/go-git/v5 v5.12.0 | ||
| github.com/goccy/go-json v0.10.2 | ||
| github.com/google/go-github v17.0.0+incompatible | ||
| github.com/google/uuid v1.4.0 | ||
| github.com/googollee/go-socket.io v1.7.0 | ||
| github.com/gorilla/websocket v1.5.3 |
There was a problem hiding this comment.
why gorialla we had preferred socketio over it
There was a problem hiding this comment.
https://github.com/googollee/go-socket.io we had moved ahead with socketio for better lifecycle and rejected this @czezi
| github.com/gin-gonic/gin v1.10.0 | ||
| github.com/go-git/go-git/v5 v5.12.0 | ||
| github.com/goccy/go-json v0.10.2 | ||
| github.com/google/go-github v17.0.0+incompatible | ||
| github.com/google/uuid v1.4.0 | ||
| github.com/googollee/go-socket.io v1.7.0 | ||
| github.com/gorilla/websocket v1.5.3 |
There was a problem hiding this comment.
https://github.com/googollee/go-socket.io we had moved ahead with socketio for better lifecycle and rejected this @czezi
| @@ -42,7 +45,6 @@ require ( | |||
| github.com/emirpasic/gods v1.18.1 // indirect | |||
| github.com/gabriel-vasile/mimetype v1.4.3 // indirect | |||
| github.com/gin-contrib/sse v0.1.0 // indirect | |||
| github.com/gin-contrib/zap v1.1.3 // indirect | |||
There was a problem hiding this comment.
why are package getting removed?
There was a problem hiding this comment.
they are just moved up
| @@ -54,7 +56,6 @@ require ( | |||
| github.com/golang/protobuf v1.5.4 // indirect | |||
| github.com/gomodule/redigo v1.9.2 // indirect | |||
| github.com/google/go-querystring v1.1.0 // indirect | |||
| github.com/gorilla/websocket v1.5.3 // indirect | |||
There was a problem hiding this comment.
why is this removed?
There was a problem hiding this comment.
they are just moved up
| r.Use(TerminalGinMiddleware("http://localhost:3000, https://developer.superagi.com")) | ||
| r.RedirectTrailingSlash = false | ||
|
|
||
| api := r.Group("/api") |
There was a problem hiding this comment.
I guess we should structure inside gateways all the websocket like in the other use cases @czezi what do you say?
Fluder-Paradyne
force-pushed
the
terminal-poc
branch
from
e36fadb to
6d8bce0
Compare
Description
Add terminal to workbench
Related Issues
Solution and Design
Test Plan
Type of change
Checklist