Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nd expression testing #52

Closed
wants to merge 32 commits into from
Closed

Nd expression testing #52

wants to merge 32 commits into from

Conversation

Transurgeon
Copy link
Owner

Description

Please include a short summary of the change.
Issue link (if applicable):

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

Transurgeon and others added 30 commits June 4, 2024 12:00
initial changes to begin enabling nd expressions
0438115
some more nitpicky changes
047214a
adding initial testing prototype for nd sum atom
3c03a0d
adding more tests for elementwise operations
531d281
updating test docstrings thanks to philipp
abf41bc
some progress but still missing out on test cases
746fc8a
fixing issue with output shape instead of input
9bbf5ab
adding arg to test
f8d853a
moving test to new class
79fd4b2
resetting changes to settings
1dd6e0c
removing type annotation for constant.py
a800dda
copying implementation over to scipy backend, will look into optimiza…
dfeebcb 
…tions later
update axis atom to allow multiple axes, removing some tests
8d3bc71
adding tests for passing multiple axes to the sum atom
53ae854
fixing all tests for scipy and numpy
ea47fcd
adding back axis atom error and disabling cumsum for now
1cef190
trying to setback default canon backend to cpp
a1df0a6
adding case for lin-util to differentiate with cpp backend
756d903
fixing case for data for numpy backend
98ac1c7
adding passing tests for nd sum
89c73ba
fixing issues with difference in backends, will need to make changes …
03b6060 
…to solving chain as well
adding changes to backend choice depending on number of dimensions of…
728ed8b 
… vars and params
fixing ndim of problem and constraints check to be more accurate
02f7fb2
final changes, removing comments for assertions and updating docstrings
e29f893
adding backend strings from settings, adjusting test accordingly
d417839
fixing changes from review by steven
8df43ef
removing axis type check with iterable
15cf2fd
making changes following Parth's review
08111d9
@Transurgeon @PTNobel
Update cvxpy/expressions/constants/constant.py
b0bec73 
Co-authored-by: Parth Nobel <parthnobel@berkeley.edu>
@Transurgeon @PTNobel
Update cvxpy/lin_ops/canon_backend.py
76025da 
Co-authored-by: Parth Nobel <parthnobel@berkeley.edu>
@Transurgeon Transurgeon closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Transurgeon