chore: removal of default prop values #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added workaround
commit: |
alvarosabu
requested changes
Jan 11, 2025
| offset: () => new Vector2(0.01, 0.01), | ||
| radialModulation: false, | ||
| modulationOffset: 0.15, | ||
| radialModulation: undefined, |
There was a problem hiding this comment.
why do we set it to undefined here? Wouldn't be better not to use withDefaults here @Tinoooo ?
There was a problem hiding this comment.
We have to set it to undefined to prevent Vue from casting it to boolean when the prop is not in use. Without this line, we have no chance to find out whether the prop was actively set or not.
| @@ -16,8 +17,7 @@ export interface NoisePmndrsProps { | |||
|
|
|||
| <script lang="ts" setup> | |||
| const props = withDefaults(defineProps<NoisePmndrsProps>(), { | |||
| premultiply: false, | |||
| blendFunction: BlendFunction.SCREEN, | |||
| premultiply: undefined, | |||
There was a problem hiding this comment.
same here, wouldn't be better to remove the withDefault all along?
There was a problem hiding this comment.
We have to set it to undefined to prevent Vue from casting it to boolean when the prop is not in use. Without this line, we have no chance to find out whether the prop was actively set or not.
….com/Tresjs/post-processing into chore/removal-of-default-prop-values
alvarosabu
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the prop watcher helper to retrieve default constructor values from plain effects, we must not set default values in the effect component's props ourselves. This MR removes the default values from the prop definitions in the affected effects.