Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-8534 SmartOS UI minimum viable product #68

Merged
merged 2 commits into from
May 30, 2024
Merged

OS-8534 SmartOS UI minimum viable product #68

merged 2 commits into from
May 30, 2024

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented May 29, 2024

No description provided.

@robbyandrews
Copy link
Contributor

In the first and third paragraphs sometimes UI is capitalized and sometimes lowercase, so minor suggestion of just uniformly capitalizing UI in those parts.

docs/web-interface.md Outdated Show resolved Hide resolved
in a more inviting way.

Note that while we have tried to make sure SmartOS features are represented in
the web ui, not all features are yet exposed. And due to the nature of SmartOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui to UI suggestion here as well.

Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Robby's comments and I'm good.

Also, not a blocker now, but maybe in the future include some pictures?

docs/web-interface.md Outdated Show resolved Hide resolved
@bahamat bahamat merged commit c5f65ab into master May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants