Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/christensophia/team page #12

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Conversation

syz16
Copy link
Member

@syz16 syz16 commented Jan 27, 2024

Tracking Info

Resolves #7

Changes

We made the Our Team Page with two resuable components, one for a background header defined in BackgroundHeader.ts and MemberInfo.tsx. We also implemented a back-end with a POST member route and GET all member route to fetch all members to display data.

Testing

We used Postman to test the API calls and tested with a variety of data on the website. The data is successfully displaying on the website.

Confirmation of Change

Screenshot 2024-01-27 at 12 06 43 PM Screenshot 2024-01-27 at 12 06 54 PM

@syz16 syz16 requested a review from jennymar as a code owner January 27, 2024 20:09
@jennymar jennymar requested a review from katelynpdn February 3, 2024 17:48
Copy link
Collaborator

@jennymar jennymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I fixed some of the css for Our Team page and MemberInfo component, including fonts and spacing, as well as moved the components into a components directory. Great work guys!

Copy link
Member

@katelynpdn katelynpdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend page and backend look great!

@syz16 syz16 merged commit 2982966 into main Feb 11, 2024
2 checks passed
@syz16 syz16 deleted the feature/christensophia/team-page branch February 11, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Our Team Page
4 participants