Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/kevinkatelyn/navigation bar #17

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Feature/kevinkatelyn/navigation bar #17

merged 10 commits into from
Feb 20, 2024

Conversation

katelynpdn
Copy link
Member

Tracking Info

Resolves #3

Changes

  • Created a navigation bar component that contains the 4FLOT logo and text options to scroll over
  • Added the text options' dropdown menus, as well as a donate button

Testing

  • We confirmed our changes worked by comparing the bar and dropdown menus side-by-side with the Figma navigation bar.

Confirmation of Change

Screenshot 2024-02-05 at 6 09 57 PM

@katelynpdn katelynpdn requested a review from jennymar as a code owner February 6, 2024 02:13
@jennymar jennymar requested a review from Arnav710 February 8, 2024 05:59
jennymar
jennymar approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@jennymar jennymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added the HeaderBar component you guys made into layout.tsx so that it will render on every page, as well as changed the tags to tags for internal links. Great work!

Arnav710
Arnav710 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Arnav710 Arnav710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you hover over any of the fields in the navigation bar (eg. about us, get involved) vs their subfields (eg. our mission, upcoming events) the type of cursor looks different. Other than that, looks good to me!

@jennymar jennymar merged commit 2608c09 into main Feb 20, 2024
2 checks passed
@jennymar jennymar deleted the feature/kevinkatelyn/navigation-bar branch February 20, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arnav710 Arnav710 Arnav710 approved these changes

@jennymar jennymar jennymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation Bar - Desktop
4 participants
@katelynpdn @jennymar @Arnav710 @kevindo0720